<html>
<head><meta charset="utf-8"><title>Waiting for reviews on RFC PR (--check-cfg) · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html">Waiting for reviews on RFC PR (--check-cfg)</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="217188274"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217188274" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217188274">(Nov 18 2020 at 19:56)</a>:</h4>
<p>Hey, folks. I submitted this PR <a href="https://github.com/rust-lang/rfcs/pull/3013">https://github.com/rust-lang/rfcs/pull/3013</a> for an RFC for a compiler feature (verifying the correct usage of <code>#[cfg]</code>). After an initial round of feedback (largely positive, and I've made edits to reflect feedback), it looks like no one is reviewing this.</p>
<p>It's been 2 weeks now. Could someone look at this? Or let me know when this might advance?</p>



<a name="217191818"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217191818" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217191818">(Nov 18 2020 at 20:24)</a>:</h4>
<p>Tagging <span class="user-mention" data-user-id="125270">@scottmcm</span> , since you were mentioned in the PR thread.</p>



<a name="217193063"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217193063" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217193063">(Nov 18 2020 at 20:34)</a>:</h4>
<p>I've marked it T-lang, and nominated for discussion at our next triage meeting.</p>



<a name="217193152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217193152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217193152">(Nov 18 2020 at 20:35)</a>:</h4>
<p>Thanks. Partly I'm doing this RFC as a way to learn the RFC process. Are the triage meetings open to the public?</p>



<a name="217193164"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217193164" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217193164">(Nov 18 2020 at 20:35)</a>:</h4>
<p>(Based on the statement that it's a lang issue.)</p>



<a name="217193263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217193263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217193263">(Nov 18 2020 at 20:36)</a>:</h4>
<p>yes, triage is open to the public and posted on youtube. <a href="https://lang-team.rust-lang.org/meetings.html">https://lang-team.rust-lang.org/meetings.html</a></p>



<a name="217193518"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217193518" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217193518">(Nov 18 2020 at 20:38)</a>:</h4>
<p>Hmm, I wonder where the appropriate home for this is.  Part of the trouble with this one is that it looks like it cross-cuts cargo and compiler and lang, in a way.</p>



<a name="217193573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217193573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Arlie Davis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217193573">(Nov 18 2020 at 20:39)</a>:</h4>
<p>I'll join in, in case anyone has any questions about this.</p>



<a name="217193923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Waiting%20for%20reviews%20on%20RFC%20PR%20%28--check-cfg%29/near/217193923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Waiting.20for.20reviews.20on.20RFC.20PR.20(--check-cfg).html#217193923">(Nov 18 2020 at 20:42)</a>:</h4>
<p>As you say, "Language semantics are unchanged", so lang's involvement is probably only whether the lint would push people to write their code in a way that's not a direction we'd want, but I don't think that's really the case with this one.</p>
<p>I'll tag it Cargo too.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>